Skip to content

feat(inlet): add low-latency two-phase chunk pulls - #116

Merged
cboulay merged 2 commits into
mainfrom
cboulay/two_phase_pull
Sep 20, 2026
Merged

cboulay merged 2 commits into
mainfrom
cboulay/two_phase_pull

Conversation

@cboulay

@cboulay cboulay commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an opt-in min_samples argument to StreamInlet.pull_chunk
  • support waiting for the first sample and then draining immediately available data up to max_samples
  • preserve the existing pull behavior when min_samples is omitted
  • preserve preallocated dest_obj support across both pull phases

Testing

  • uv run pytest -q — 22 passed, 2 skipped
  • uv run ruff check src/pylsl/inlet.py test/test_pull_chunk.py
  • verified the editable dependency from ezmsg-lsl and ran its inlet tests — 6 passed

@cboulay
cboulay deleted the branch main September 20, 2026 03:57
@cboulay cboulay closed this Sep 20, 2026
@cboulay cboulay reopened this Sep 20, 2026
@cboulay
cboulay changed the base branch from chore/liblsl-1.18.0b2 to main September 20, 2026 03:57
@cboulay
cboulay merged commit 297e705 into main Sep 20, 2026
6 checks passed
@cboulay
cboulay deleted the cboulay/two_phase_pull branch September 20, 2026 03:58
cboulay added a commit to adityasingh2400/pylsl that referenced this pull request Sep 20, 2026
The style job started failing on main without any code change: uv.lock
is gitignored, so CI resolves ruff fresh and now gets 0.16.x, whose
expanded default rule selection reports 78 pre-existing findings.
Select the classic default set (E4, E7, E9, F) explicitly so results
don't depend on the installed ruff version.

Also apply ruff format to two files left unformatted by labstreaminglayer#116.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant